Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quinn-udp version to 0.4 #1535

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Bump quinn-udp version to 0.4 #1535

merged 1 commit into from
Apr 19, 2023

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Apr 14, 2023

It includes a fallback for old Linux and Android systems which do not support setting ECN flag on UDP packets.

@link2xt
Copy link
Contributor Author

link2xt commented Apr 14, 2023

Since quinn-udp depends on unpublished quinn-proto 0.10, quinn-proto should be published first.

@Ralith
Copy link
Collaborator

Ralith commented Apr 14, 2023

A breaking public dependency version change is a breaking change, so this should be 0.4.

@djc
Copy link
Member

djc commented Apr 19, 2023

@link2xt can you bump this to 0.4.0, please?

@link2xt link2xt changed the title Bump quinn-udp version to 0.3.3 Bump quinn-udp version to 0.4 Apr 19, 2023
@link2xt
Copy link
Contributor Author

link2xt commented Apr 19, 2023

Rebased and bumped to 0.4

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the version number quinn asks for to match.

It includes a fallback for old Linux and Android systems
which do not support setting ECN flag on UDP packets.
@djc djc merged commit ec7a459 into quinn-rs:main Apr 19, 2023
@djc djc mentioned this pull request May 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants