Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename min_guaranteed_mtu to min_mtu for clarity #1551

Closed
wants to merge 6 commits into from
Closed

Rename min_guaranteed_mtu to min_mtu for clarity #1551

wants to merge 6 commits into from

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Apr 29, 2023

Depends on #1529.

@aochagavia
Copy link
Contributor

We should probably rename usages of min_guaranteed_mtu in other places too. See the function parameters of MtuDiscovery::{new, disabled, with_state} and BlackHoleDetector::new, and the min_guaranteed_mtu field of BlackHoleDetector.

@Ralith
Copy link
Collaborator Author

Ralith commented May 1, 2023

Good catch, thanks; fixed.

@aochagavia aochagavia mentioned this pull request May 3, 2023
Merged
@aochagavia
Copy link
Contributor

@Ralith I have created #1552 to save you the hassle of rebasing 😉

@djc djc closed this May 3, 2023
@djc djc deleted the plpmtud-2 branch May 3, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ralith @aochagavia @djc