Use boxed AsyncUdpSocket when creating abstract endpoint #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jun 29, 2023
Ralith
reviewed
Jun 29, 2023
djc
reviewed
Jun 30, 2023
| } | ||
|
|
||
| fn new_with_runtime( | ||
| fn new_with_abstract_socket( |
There was a problem hiding this comment.
Um, this replaced the public constructor with only a private one. That doesn't seem like the right direction?
There was a problem hiding this comment.
Ops. Sorry my bad. #1596
There was a problem hiding this comment.
To be fair, it's also @Ralith's bad for not catching it in review! Thanks for following up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the std socket with either
TokioRuntimeorAsyncStdRuntimereturnsBox<dyn AsyncUdpSocket>. Creating an endpoint with an abstract socket requiresimpl AsyncUdpSocketand it is therefore not possible to use a wrapped socket together withnew_with_abstract_socket.This MR fixes this inconsistency by using
Box<dyn AsyncUdpSocket>innew_with_abstract_socket.