Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the tracing span in the EndpointDriver task #1616

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Preserve the tracing span in the EndpointDriver task #1616

merged 1 commit into from
Jul 27, 2023

Commits on Jul 26, 2023

  1. Preserve the tracing span in the EndpointDriver task 

    The EndpointDriver is spawned in a task.  Unless the span is copied
into this task the current span is lost.

Copying the current span means any tracing calls inside the driver,
from e.g. a custom AsyncUdpSocket, are preserved in the span.  This
makes it easy to use different parent spans for different endpoints
and have log messages appear with their parent span.  Otherwise these
log messages are not attached to a span.
    @flub
    flub committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ed096d8 View commit details
    Browse the repository at this point in the history