Fix constant of frame_type IMMEDIATE_ACK #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the draft and the IANA registry say the current value for frame_type IMMEDIATE_ACK is 0x1F. https://www.iana.org/assignments/quic/quic.xhtml https://datatracker.ietf.org/doc/html/draft-ietf-quic-ack-frequency#section-10.2 Co-Authored-By: Tamas Levai <levait@tmit.bme.hu>
djc
approved these changes
Mar 6, 2024
It is not necessary. We're not interested in interoperability just yet. Thank you. |
|
Who is we? What's your interest/use case? |
Ralith
approved these changes
Mar 6, 2024
I guess @nemethf was referring to me. 😄 We are experimenting with real-time media traffic, and it turns out that both gstreamer quicsink/quicsrc and moq-rs uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the draft and the IANA registry say the current value for frame_type IMMEDIATE_ACK is 0x1F.
https://www.iana.org/assignments/quic/quic.xhtml
https://datatracker.ietf.org/doc/html/draft-ietf-quic-ack-frequency#section-10.2