Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct MTU for prev_path #1776

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Use the correct MTU for prev_path #1776

merged 1 commit into from
Apr 2, 2024

Conversation

nemethf
Copy link
Contributor

@nemethf nemethf commented Mar 7, 2024

I've just bumped into this. I'm not confident this is really a bug, but using the MTU of a different path seems a wrong thing to do.

djc
djc approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to make more sense, thanks for pointing it out!

@djc
Copy link
Member

djc commented Mar 26, 2024

@nemethf did you want to follow up on this?

@nemethf
Copy link
Contributor Author

nemethf commented Mar 27, 2024

@nemethf did you want to follow up on this?

Should I update the PR with reserve(MIN_INITIAL_SIZE)? (I'm okay with @Ralith or you do it.)

@djc
Copy link
Member

djc commented Mar 27, 2024

@nemethf did you want to follow up on this?

Should I update the PR with reserve(MIN_INITIAL_SIZE)? (I'm okay with @Ralith or you do it.)

Would be nice!

@nemethf @Ralith
Use the correct MTU for prev_path
c99a5cb 
Co-Authored-By: Benjamin Saunders <ben.e.saunders@gmail.com>
@nemethf
Copy link
Contributor Author

nemethf commented Apr 2, 2024

@nemethf did you want to follow up on this?

I force-pushed a version suggested by @Ralith. Thanks.

Ralith
Ralith approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith merged commit f879a35 into quinn-rs:main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nemethf @djc @Ralith