Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preferred address #1816

Merged
merged 2 commits into from
Apr 13, 2024
Merged

preferred address #1816

merged 2 commits into from
Apr 13, 2024

Conversation

devsnek
Copy link
Contributor

@devsnek devsnek commented Apr 9, 2024 •
edited
Loading

allows server to provide a preferred address to clients.

Ralith
Ralith reviewed Apr 9, 2024
View reviewed changes
quinn-proto/src/config.rs Outdated Show resolved Hide resolved
@devsnek devsnek force-pushed the x/preferred-addr branch 2 times, most recently from e59c381 to 8a6bcd2 Compare April 11, 2024 05:39
@devsnek devsnek marked this pull request as ready for review April 11, 2024 05:40
@djc djc mentioned this pull request Apr 12, 2024
Closed
7 tasks
@djc
Copy link
Member

djc commented Apr 12, 2024 •
edited
Loading

FYI, we're planning to release 0.11.0 soon (see #1737). This includes some semver-incompatible changes in its current form, so it would be nice to see if we can get it merged.

djc
djc approved these changes Apr 12, 2024
View reviewed changes
quinn-proto/src/tests/util.rs Outdated Show resolved Hide resolved
@djc
Copy link
Member

djc commented Apr 12, 2024

This is looking pretty good, thanks! I'll let @Ralith make a final review pass.

Ralith
Ralith requested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! It could be split into a commit that allows per-connection ServerConfigs and a commit that exposes preferred addresses, but since it's pretty easy to review regardless I won't insist on that.

quinn/src/incoming.rs Outdated Show resolved Hide resolved
Ralith
Ralith approved these changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith force-pushed the x/preferred-addr branch from 438e37d to 8a876e2 Compare April 13, 2024 02:00
@Ralith Ralith enabled auto-merge (squash) April 13, 2024 02:03
@Ralith Ralith disabled auto-merge April 13, 2024 02:03
@Ralith Ralith force-pushed the x/preferred-addr branch from 8a876e2 to 7168826 Compare April 13, 2024 02:08
@Ralith Ralith force-pushed the x/preferred-addr branch from 7168826 to bd4a511 Compare April 13, 2024 02:10
@Ralith Ralith enabled auto-merge (rebase) April 13, 2024 02:10
@Ralith Ralith merged commit 2714162 into quinn-rs:main Apr 13, 2024
8 checks passed
@devsnek devsnek deleted the x/preferred-addr branch April 13, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devsnek @djc @Ralith