Make SendStream::finish synchronous #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2024
Ralith
force-pushed
the
synchronous-finish
branch
3 times, most recently
from
f590c4b
to
57519e3
Compare
djc
approved these changes
May 2, 2024
`await`ing on this was error-prone and not very useful, since it gave little insight into application state, and was redundant to `stopped`.
UnknownStream here corresponds to graceful stream shutdown, which is not an error case.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1699.
SendStream::finishas a future has proved to be a footgun, so this converts it into a synchronous method, delegating "wait until received" duties toSendStream::stopped. We expect that to rarely be required in real applications, though it does come up several times in our tests where we specifically want some data to be received before we drop a connection or take a time measurement.