Suppress ACK-only packet sanity-check when datagrams are queued #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
fix-sendable-frames
branch
from
584cf34
to
bc1d95d
Compare
djc
approved these changes
May 8, 2024
|
How hard is it to add a test for this? (No need to block a release on this.) Do you want to add a version bump? |
Should be feasible.
Sure, soon as I finish diagnosing some related funny behavior... |
Ralith
force-pushed
the
fix-sendable-frames
branch
from
54b7fde
to
2328671
Compare
The prior logic could even produce panics if segment size falls below MIN_PACKET_SPACE.
Ralith
force-pushed
the
fix-sendable-frames
branch
from
2328671
to
ccd94fc
Compare
Ralith
force-pushed
the
fix-sendable-frames
branch
from
ccd94fc
to
c020e65
Compare
djc
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1850.
This bug caused occasional panics in debug builds in applications which send large application datagrams. The
debug_assertdid not account for the possibility of ACK-only packets arising due to queued non-ACK being too large to fit into the same packet, which became a problem when 6a8758a introduced the possibility of ACK frames being sent alongside application data (such as large application datagrams) at times when it would be illegal to send an ACK frame spontaneously on its own.