Reduce black hole detection false positives #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
better-black-holes
branch
2 times, most recently
from
30f1c05
to
3d5b28d
Compare
|
Redesigned per chat to be robust against two-pass ACK procssing, and a bit simpler than the original plan besides. Still need to add tests and some high-level overview docs, but I think I'm happy with the shape of the code. |
Ralith
force-pushed
the
better-black-holes
branch
3 times, most recently
from
4764764
to
6bfa3c4
Compare
djc
reviewed
May 12, 2024
Ralith
force-pushed
the
better-black-holes
branch
3 times, most recently
from
eb4e619
to
36c732a
Compare
|
Addressed feedback and revised documentation. Test coverage of the new capabilities still TODO. |
Ralith
force-pushed
the
better-black-holes
branch
from
36c732a
to
0cf619c
Compare
|
Added some tests; feel free to suggest any interesting cases I may have missed. |
djc
reviewed
May 15, 2024
Ralith
force-pushed
the
better-black-holes
branch
2 times, most recently
from
c68f0c9
to
cfcf5a8
Compare
In `last_burst_was_suspicious`, if the last burst contains non-suspicious packets, we bail out early. If it doesn't, `largest_suspicious_packet_lost` is necessarily equal to `largest_non_probe_lost`. No other code reads this field, so it is redundant to `largest_non_probe_lost`.
Ralith
force-pushed
the
better-black-holes
branch
from
cfcf5a8
to
26fcfa3
Compare
djc
reviewed
May 16, 2024
No worries, this isn't urgent and I'm as happy as ever to get good feedback! |
Ralith
force-pushed
the
better-black-holes
branch
from
26fcfa3
to
cb4fd90
Compare
Exactly MTU-sized datagrams aren't necessarily transmitted often, if ever. As a result, black hole detection could previously reset the MTU regularly at any nonzero packet loss rate.
Ralith
force-pushed
the
better-black-holes
branch
from
cb4fd90
to
9d2cf78
Compare
djc
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1855.
TODO: