Support openbsd #1863
Support openbsd #1863
Conversation
There was a problem hiding this comment.
Thanks for working on this!
As far as I understand ECN is not supported as part of a control message on recvmsg. So I disabled the ECN tests for it.
OpenBSD does seem to define IPV6_RECVTCLASS: https://github.com/openbsd/src/blob/35659bf2453d7eeb12fd24089cf668ca13361c18/sys/netinet6/in6.h#L330C9-L330C24
Indeed, and the socket option is being set as well still. Let me try again if I can get ENC to work for just IPv6. |
Ok, ECN now works and is tested on IPv6 but not IPv4. I've had to split some tests for that. I left the existing ecn_ipv6 test unmodified in the end but renamed it rather than fully splitting it in two. It still makes sense on it's own. |
|
This will close #1469 I believe. |
OpenBSD supports ECN on IPv6 but not on IPv4 it seems. This splits off the test cases so that IPv6 ECN support is tested in isolation.
|
It is not clear to me if the failing test is flaky or due to something I did, any hints? |
|
@Ralith thanks for the prodding, definitely better than the first version! |
This makes Quinn compile on openbsd and the test suite passes as well.
As far as I understand ECN is not supported as part of a control message on recvmsg. So I disabled the ECN tests for it.