proto: make NoInitialCipherSuite Copy #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
commented
May 21, 2024
Ralith
approved these changes
May 21, 2024
djc
force-pushed
the
error-copy
branch
3 times, most recently
from
f8c1e0d to
26a3070
Compare
Ralith
reviewed
May 21, 2024
Ralith
reviewed
May 21, 2024
Ralith
approved these changes
May 21, 2024
There was a problem hiding this comment.
If you're planning on publishing a release in the immediate future, note #1869 is outstanding with a fix for a bug that's a panic in debug mode and possible transport error in release. Can always fast-follow with that if you don't have the bandwidth for review right now though.
|
I'll try to review your open PRs before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hickory-proto::ProtoErrorKind, which will include this, implementsClone.Downstream PR: hickory-dns/hickory-dns#2217.