quinn: Make Endpoint::client dual-stack V6 by default
#1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretchenfrage
force-pushed
the
client-dual-stack-default
branch
2 times, most recently
from
927fb01
to
a98c0c7
Compare
Ralith
requested changes
Jul 2, 2024
gretchenfrage
force-pushed
the
client-dual-stack-default
branch
from
cb5ed1e
to
0bca35f
Compare
gretchenfrage
force-pushed
the
client-dual-stack-default
branch
from
0bca35f
to
8aadf70
Compare
gretchenfrage
force-pushed
the
client-dual-stack-default
branch
from
8aadf70
to
215cdd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a conversation in the crate discord [link] in which @Ralith mentioned:
This PR makes makes
quinn::Endpoint::clientusesocket2to automatically try to setIPV6_V6ONLYto false if binding to a V6 address. Modifies the documentation to match. If the call toset_only_v6errors, it logs the error as a warning, but proceeds with the rest of theclientmethod anyways.Removes the OS-based gating from
quinn'stests::echo_dualstacktest. Unfortunately(?), that tests seems to work on main for me anyways on my current system, so I'm leaning on the CI to make sure that there's not some common system where dual-stack conversion is always impossible.