Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard pre-handshake packets after the handshake #1937

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jul 24, 2024

Attempting to parse frames from these non-frame-bearing packets was responsible for some spurious connection failures in interop testing under high packet loss.

@djc
Copy link
Member

djc commented Jul 24, 2024

MSRV failure is unrelated (see #1939).

@djc djc enabled auto-merge (rebase) July 24, 2024 08:36
@djc djc disabled auto-merge July 24, 2024 08:37
@Ralith Ralith force-pushed the fix-late-version-negotiate branch from 649f81a to 1da19b3 Compare July 25, 2024 03:47
@Ralith Ralith enabled auto-merge (rebase) July 25, 2024 03:47
Attempting to parse frames from these non-frame-bearing packets was
responsible for some spurious connection failures in interop testing
under high packet loss.
@Ralith Ralith force-pushed the fix-late-version-negotiate branch from 1da19b3 to 3173ae0 Compare July 25, 2024 04:50
@Ralith Ralith merged commit d7abf0a into main Jul 25, 2024
8 checks passed
@Ralith Ralith deleted the fix-late-version-negotiate branch July 25, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants