Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Handshake Confirmed state #1944

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Expose the Handshake Confirmed state #1944

merged 1 commit into from
Jul 28, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jul 27, 2024

This is convenient for some client authentication use cases, and for tests to know when it's safe to force a key update.

@Ralith
Copy link
Collaborator Author

Ralith commented Jul 27, 2024

This probably needs a test that it actually fails if client auth is required and not successful...

@Ralith
Copy link
Collaborator Author

Ralith commented Jul 27, 2024

Ah, reject_missing_client_cert already covers that 🎉

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

quinn/src/connection.rs Outdated Show resolved Hide resolved
This is convenient for some client authentication use cases, and for
tests to know when it's safe to force a key update.
@Ralith Ralith enabled auto-merge July 28, 2024 23:37
@Ralith Ralith added this pull request to the merge queue Jul 28, 2024
Merged via the queue into main with commit 391824b Jul 28, 2024
8 checks passed
@Ralith Ralith deleted the handshake-confirmed branch July 28, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants