-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of aws-lc-rs instead of ring #1962
Open
djc
wants to merge
3
commits into
main
Choose a base branch
from
aws-lc-rs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
aws-lc-rs
branch
3 times, most recently
from
August 8, 2024 09:14
79d62a0
to
267ccbb
Compare
Ralith
reviewed
Aug 8, 2024
Merged
Would you provide an option to disable both aws-lc-rs and ring? I would like to try another third-party adapter. |
This should already be the case both in released versions and once this PR is merged. |
djc
force-pushed
the
aws-lc-rs
branch
4 times, most recently
from
September 16, 2024 09:58
4e808d4
to
424502f
Compare
Addressed comments and added CI job to test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs a CI workflow to ensure that this actually works.