fix: remove unnecessary params being passed to amp-carousel

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.5.0](https://github.com/quintype/quintype-amp/compare/v1.5.0-amp-carousel-bugfix.0...v1.5.0) (2020-06-30)
+
 ## [1.4.0](https://github.com/quintype/quintype-amp/compare/v1.0.25...v1.4.0) (2020-06-26)
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/amp",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "Quintype's AMP component library for publisher apps to create amp layouts",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/__fixtures__/all-element-story.fixture.ts

@@ -151,6 +151,97 @@ const allElementsStory = {
           text:
             "<p>In general—and this is a good P.S.A. reminder for everyone—if you are symptomatic, you are supposed to stay home for seven days, or three days past whenever your symptoms resolve, whichever one of those is longest. [If you have been in close contact with a person who has tested positive and you are asymptomatic, experts recommend staying home for fourteen days after that contact.] If I don’t get tested, I’ll stay home for seven days. But if I do get tested and I test negative, I could go back.</p>"
         },
+        {
+          description: "",
+          "page-url": "/story/af018d6b-2166-4344-b167-40405a148e41/element/a50b2136-c18b-4dd9-a2b2-0df96e2c253a",
+          type: "composite",
+          "family-id": "88e7df74-fe20-42ad-b5aa-54de86108fc4",
+          "story-elements": [
+            {
+              description: "",
+              "image-metadata": {
+                width: 656,
+                height: 280
+              },
+              type: "image",
+              "family-id": "fae56324-4c23-45b7-baac-81da10ae5ff6",
+              "image-attribution": "Attribution of an imitation game",
+              title: "Chase: An Imitation Game - A Story On Dharavi's Fake Leather Bags",
+              id: "5c375339-5fb0-481a-a811-ae271d894b3b",
+              "image-s3-key":
+                "ace/2020-03/ad503d63-4d05-41e6-9722-fdfe3acb2405/handwashing_8_wide_eb1f71948877c7a15d27a82cd7d90b324b956a89.jpg",
+              metadata: {},
+              subtype: null
+            },
+            {
+              description: "",
+              "image-metadata": {
+                width: 326,
+                height: 155
+              },
+              type: "image",
+              "family-id": "953a1d2c-d52d-4b13-8af5-969e74813197",
+              "image-attribution": "Ramsharan Gorur Jayaraman",
+              title: "Caption",
+              id: "48b14295-99ed-4fc8-ad99-4cb1d85a29ae",
+              "image-s3-key": "ace/2019-06/051658dc-43f0-4945-92bd-f2da2a206e40/panda.jpg",
+              metadata: {},
+              subtype: null
+            }
+          ],
+          title: "",
+          id: "a50b2136-c18b-4dd9-a2b2-0df96e2c253a",
+          metadata: {
+            type: "slideshow"
+          },
+          subtype: "image-gallery"
+        },
+        {
+          description: "",
+          "page-url": "/story/af018d6b-2166-4344-b167-40405a148e41/element/db5dd415-e4e1-41f8-83af-48f771fe22ec",
+          type: "composite",
+          "family-id": "015f0be5-428f-47f2-86ff-fba42be6c77b",
+          "story-elements": [
+            {
+              description: "",
+              "image-metadata": {
+                width: 1200,
+                height: 520
+              },
+              type: "image",
+              "family-id": "6532027a-f855-474c-8651-dbdd96de3b39",
+              "image-attribution": "",
+              title: "Are college interviews now a saffron litmus test?",
+              id: "36452445-2155-496a-b471-de48870b713a",
+              "image-s3-key": "ace/2019-06/051658dc-43f0-4945-92bd-f2da2a206e40/panda.jpg",
+              metadata: {},
+              subtype: null
+            },
+            {
+              description: "",
+              "image-metadata": {
+                width: 3128,
+                height: 3910,
+                "focus-point": [350, 3166]
+              },
+              type: "image",
+              "family-id": "e343544a-93b4-43d8-bc52-2c3a63adeac7",
+              "image-attribution": "unsplash",
+              title: "Traffic cones",
+              id: "0898278c-9fac-4685-a0ae-d9caf8c1e7a7",
+              "image-s3-key":
+                "ace/2020-03/ad503d63-4d05-41e6-9722-fdfe3acb2405/handwashing_8_wide_eb1f71948877c7a15d27a82cd7d90b324b956a89.jpg",
+              metadata: {},
+              subtype: null
+            }
+          ],
+          title: "",
+          id: "db5dd415-e4e1-41f8-83af-48f771fe22ec",
+          metadata: {
+            type: "gallery"
+          },
+          subtype: "image-gallery"
+        },
         {
           description: "",
           "embed-js":

src/atoms/carousel/carousel.tsx

@@ -3,7 +3,7 @@ import { Helmet } from "react-helmet";
 import { CarouselTypes } from "./types";
 import { LightboxGallery } from "../lightbox-gallery";
 
-export const Carousel = ({ children, ...props }: CarouselTypes) => {
+export const Carousel = (props: CarouselTypes) => {
   return (
     <Fragment>
       <Helmet>
@@ -14,7 +14,7 @@ export const Carousel = ({ children, ...props }: CarouselTypes) => {
         />
       </Helmet>
       {props.lightbox && <LightboxGallery />}
-      <amp-carousel {...props}>{children}</amp-carousel>
+      <amp-carousel {...props} />
     </Fragment>
   );
 };

src/atoms/story-elements/image-gallery-element/image-gallery-element.tsx

@@ -87,7 +87,7 @@ export const ImageGalleryElementBase = ({ element, story, config }: StoryElement
   return imageGalleryElementRender ? (
     imageGalleryElementRender({ story, config, element })
   ) : (
-    <DefaultImageGalleryElement element={element} story={story} config={config} />
+    <DefaultImageGalleryElement element={element} />
   );
 };
 

src/helpers/ampify-story/ampify-story.test.ts

@@ -4,7 +4,15 @@
 
 import { ampifyStory } from "./ampify-story";
 import { isValidAmpHtml } from "../../utils/validate-amp";
-import { storyWithManyJsEmbeds, publisherConfig, ampConfig, relatedStories, configOpts, seo } from "../../__fixtures__";
+import {
+  allElementsStory,
+  storyWithManyJsEmbeds,
+  publisherConfig,
+  ampConfig,
+  relatedStories,
+  configOpts,
+  seo
+} from "../../__fixtures__";
 import { sampleTextStory } from "./sampleTextStory";
 
 describe("Ampify Story with custom opts", () => {
@@ -27,7 +35,7 @@ describe("Ampify Story with custom opts", () => {
 
   it("ampifyStory function should return valid amp-html", async () => {
     const ampHtml = ampifyStory({
-      story: storyWithManyJsEmbeds,
+      story: allElementsStory,
       publisherConfig,
       ampConfig,
       opts: configOpts,

src/molecules/date/updated/__snapshots__/date-updated.test.tsx.snap

@@ -2,7 +2,7 @@
 
 exports[`DateUpdated should match snapshot 1`] = `
 <Component
-  formattedDate="4 months ago"
+  formattedDate="5 months ago"
   prepend="Story Updated:"
 />
 `;