Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from github emojis to standard emojis #198

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Jul 22, 2021

Just use the standard ones for the fixable/recommended emojis.

Code editors like VSCode can't render :white_check_mark: but they can render standard emojis like ✅. Standard emojis are more universal and don't require special rendering engines. Easier to work with and preview locally.

@coveralls
Copy link

coveralls commented Jul 22, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 927a7ea on bmish:docs-emojis into 742325c on platinumazure:master.

@platinumazure
Copy link
Collaborator

Changes generally look good, but I'll want to check how this looks in your branch when I'm on PC.

What's the motivation for this change? Does this solve a specific problem?

@bmish
Copy link
Member Author

bmish commented Jul 22, 2021

Code editors like VSCode can't render :white_check_mark: but they can render standard emojis like ✅. Standard emojis are more universal and don't require special rendering engines. Easier to work with and preview locally.

@platinumazure platinumazure merged commit fce1e12 into qunitjs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants