Build: Move wrap/unwrap helpers to testUtils #216
Conversation
|
|
||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // Helpers | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| function wrap(assertionCode, testName = "Name") { |
There was a problem hiding this comment.
Some versions of wrap contained a testName argument, but it was never used. If it's needed in the future it can be added back.
| @@ -0,0 +1,13 @@ | |||
| /** | |||
There was a problem hiding this comment.
I would add this to tests/utils/wrap.js instead, so eventually we can have multiple test util files.
There was a problem hiding this comment.
I used the same structure as the non-test utils in lib/utils.js, should they not be the same?
There was a problem hiding this comment.
We can split into multiple utility files later if needed.
There was a problem hiding this comment.
Will improve util organization later then.
tests/lib/rules/assert-args.js
Outdated
|
|
||
| // unwrapped | ||
| // untestUtils.wrapped |
There was a problem hiding this comment.
I assume this should be reverted
| @@ -0,0 +1,13 @@ | |||
| /** | |||
There was a problem hiding this comment.
We can split into multiple utility files later if needed.
No description provided.