Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace cleaning preserves URLs with ports #1769

Closed
Krinkle opened this issue Jun 20, 2024 · 1 comment
Closed

Stack trace cleaning preserves URLs with ports #1769

Krinkle opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
Component: Core For module, test, hooks, and reporters. Type: Bug Something isn't working right.

Comments

@Krinkle
Copy link
Member

Krinkle commented Jun 20, 2024

When serving test suites from a URL like localhost:4000/test/index.html, QUnit's stack trace cleaner doesn't work. This falls back gracefully to showing the full stack trace, but we could do better here.

Example from the MediaWiki VisualEditor test suite:

ve.ui.UrlStringTransferHandler.static.matchFunction@http://localhost:4000/load.php/ext.visualEditor.core:55909:2
ve.ce.Surface.prototype.afterPaste@http://localhost:4000/load.php/ext.visualEditor.core:34356:18
ve.test.utils.runSurfacePasteTest@http://localhost:4000/load.php/test.VisualEditor/26712:28
@http://localhost:4000/load.php/test.VisualEditor:29497:8
runTest@http://localhost:4000/resources/lib/qunitjs/qunit.js:2697:35
run@http://localhost:4000/resources/lib/qunitjs/qunit.js:2680:16
queue/runTest/<@http://localhost:4000/resources/lib/qunitjs/qunit.js:2951:16
processTaskQueue@http://localhost:4000/resources/lib/qunitjs/qunit.js:2271:26
processTaskQueue/<@http://localhost:4000/resources/lib/qunitjs/qunit.js:2275:29

This affects both the HTML Reporter and the TAP Reporter (QUnit CLI) alike. It's shared code, exposed via testEnd event data to reporters.

The bottom half should have been trimmed off by the stacktrace cleaner.

@Krinkle Krinkle added Component: HTML Reporter Type: Bug Something isn't working right. labels Jun 20, 2024
@Krinkle Krinkle self-assigned this Jun 20, 2024
@Krinkle Krinkle added Component: CLI Component: Core For module, test, hooks, and reporters. and removed Component: HTML Reporter Component: CLI labels Jun 20, 2024
@Krinkle
Copy link
Member Author

Krinkle commented Jul 19, 2024

Before After
Screenshot Screenshot

Krinkle added a commit that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core For module, test, hooks, and reporters. Type: Bug Something isn't working right.
Development

No branches or pull requests

1 participant