Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert: Reset internal steps list after verifySteps #1233

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Assert: Reset internal steps list after verifySteps #1233

merged 1 commit into from
Nov 8, 2017

Conversation

trentmwillis
Copy link
Member

Fixes #1227

platinumazure
platinumazure approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

rwjblue
rwjblue reviewed Nov 8, 2017
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - thanks for working on this @trentmwillis!

@trentmwillis trentmwillis merged commit 6a7910a into qunitjs:master Nov 8, 2017
@trentmwillis trentmwillis deleted the verify-steps-reset branch November 8, 2017 20:49
@trentmwillis trentmwillis mentioned this pull request Nov 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trentmwillis @rwjblue @platinumazure