Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unhandled rejections cause test failure. #1241

Merged
merged 8 commits into from
Dec 20, 2017
Merged

Ensure unhandled rejections cause test failure. #1241

merged 8 commits into from
Dec 20, 2017

Commits on Dec 18, 2017

  1. CLI: Ensure an unhandled rejection results in a failed test.

    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    336b32e View commit details
    Browse the repository at this point in the history

  2. HTML Reporter: Ensure unhandled rejection fails. 

    Brings unhandled rejections in line with unhandled exceptions.
    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    bc23a65 View commit details
    Browse the repository at this point in the history

  3. Core: Add QUnit.onUnhandledRejection.

    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    42eebf7 View commit details
    Browse the repository at this point in the history

  4. Tests: Update tests for unhandled rejection scenarios. 

    * Properly feature detect the browsers ability to report unhandled
  rejections
* Ensure unhandled rejections are tested for both inside and outside of
  a test
    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    f3e30f4 View commit details
    Browse the repository at this point in the history

  5. Core: Capture the proper stack trace in onUnhandledRejection.

    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    9a77ca4 View commit details
    Browse the repository at this point in the history

  6. Tests: Update CLI test and test fixture to remove stacktrace ambiguity. 

    Unfortunately, we cannot use real errors here because the stack trace
representation changes across Node versions (and therefore the
expectations fail).
    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6a6fae8 View commit details
    Browse the repository at this point in the history

  7. Tests: Fixup comment indentation.

    @rwjblue
    rwjblue committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    455ac83 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Tests: Address feedback, use more idiomatic promise chaining.

    @rwjblue
    rwjblue committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    4b955d1 View commit details
    Browse the repository at this point in the history