Assert: Clone actual steps array to avoid passing internal reference #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
approved these changes
Mar 1, 2018
rwjblue
reviewed
Mar 1, 2018
|
|
||
| var loggedAssertions = {}; | ||
|
|
||
| QUnit.log( function( details ) { |
There was a problem hiding this comment.
Given that (AFAIK) these functions cannot be removed, this QUnit.log will continue to fill loggedAssertions for all subsequent (and unrelated) tests, right?
Does that pose a concern (or maybe it’s “fine”)?
There was a problem hiding this comment.
It only ever logs entries into loggedAssertions["verification-assertion"], so I don't see much of an issue with it (given that I don't believe any other assertion has that message in our code base)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266
The test setup is a bit awkward to verify this fix, so if anyone has a better idea, let me know!