Core: Ensure late-add high-priority tests are inserted in proper order #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The weird behavior in PhantomJS is due to |
|
Thanks for that insight, I would have never figured that out! Will update the comment in the test then. |
trentmwillis
force-pushed
the
running-priority
branch
from
5c2ccc7
to
7d6f2c9
Compare
|
Comment in the test has been updated. Should be good to go now I think. |
|
@qunitjs/qunit-team would one of you mind reviewing this for me? |
trentmwillis
force-pushed
the
running-priority
branch
from
7d6f2c9
to
daa2417
Compare
platinumazure
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment: https://github.com/qunitjs/qunit/pull/1260/files#r169779552
(Note: Test has some weird behavior in PhantomJS, but verified it works as expected in Chrome, Safari, and FireFox)