CLI: Implement --require option #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2018
platinumazure
approved these changes
Mar 2, 2018
rwjblue
approved these changes
Mar 3, 2018
Krinkle
reviewed
Mar 6, 2018
| @@ -0,0 +1,6 @@ | |||
| const resolve = require( "resolve" ); | |||
There was a problem hiding this comment.
Not related to this PR, but we seem to have grown a fair number of files in bin/ that are not intended as standalone CLI entry points. We should consider moving these to src/ instead.
There was a problem hiding this comment.
👍 agreed, though I would like to ensure we keep some clear separation between CLI code and library code (just means we likely need src/cli or something)
|
This is so cool! This should mean |
Krinkle
added a commit
that referenced
this pull request
Dec 27, 2018
Krinkle
added a commit
that referenced
this pull request
Dec 27, 2018
trentmwillis
pushed a commit
that referenced
this pull request
Dec 27, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
--requireoption for the CLI. It allows for any number of dependencies or files to berequired prior to the test suite run actually starting.Fixes #1222