HTML Reporter: Fix XHTML output (issue 1255). #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@platinumazure : I'll try to, thanks for your comment. |
|
@platinumazure : added a test - it gets stuck w the fix commit reverted and succeeds with the change. see commit 5457418 . |
|
Thanks @shlomif! This looks good to me, but I'd like another set of eyes on this before merging. |
|
On Thu, 04 Oct 2018 05:38:48 -0700 Kevin Partington ***@***.***> wrote:
Thanks @shlomif!
This looks good to me, but I'd like another set of eyes on this before
merging.
thanks!
…--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
http://www.shlomifish.org/humour/ways_to_do_it.html
XSLT is the number one cause of programmers’ suicides since Visual Basic 1.0.
— http://www.shlomifish.org/humour/bits/facts/XSLT/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
|
|
On Mon, 08 Oct 2018 13:07:31 -0700 Trent Willis ***@***.***> wrote:
Merged #1317 into master.
thanks, and you are welcome!
…--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
Funny Anti-Terrorism Story - http://shlom.in/enemy
SMG: It was 1997-1998ish, Buffy started airing. So one day a group of
yeshivah pupils arrived to the studios saying they have some numereological
insights from the Jewish bible, about what will happen in Sunnydale next.
— http://www.shlomifish.org/humour/Summerschool-at-the-NSA/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1255 . There was a tag without a closing / that confused the browser when using XHTML.