-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Reporter: Fix XHTML output (issue 1255). #1317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to write a unit test for this change?
@platinumazure : I'll try to, thanks for your comment. |
@platinumazure : added a test - it gets stuck w the fix commit reverted and succeeds with the change. see commit 5457418 . |
Thanks @shlomif! This looks good to me, but I'd like another set of eyes on this before merging. |
On Thu, 04 Oct 2018 05:38:48 -0700 Kevin Partington ***@***.***> wrote:
Thanks @shlomif!
This looks good to me, but I'd like another set of eyes on this before
merging.
thanks!
…--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
http://www.shlomifish.org/humour/ways_to_do_it.html
XSLT is the number one cause of programmers’ suicides since Visual Basic 1.0.
— http://www.shlomifish.org/humour/bits/facts/XSLT/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
On Mon, 08 Oct 2018 13:07:31 -0700 Trent Willis ***@***.***> wrote:
Merged #1317 into master.
thanks, and you are welcome!
…--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
Funny Anti-Terrorism Story - http://shlom.in/enemy
SMG: It was 1997-1998ish, Buffy started airing. So one day a group of
yeshivah pupils arrived to the studios saying they have some numereological
insights from the Jewish bible, about what will happen in Sunnydale next.
— http://www.shlomifish.org/humour/Summerschool-at-the-NSA/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
|
See #1255 . There was a tag without a closing / that confused the browser when using XHTML.