HTML Reporter: Fix an unescaped details.source. #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an unescaped details.source in innerHTML. It became apparent when using .xhtml (application/xml+xhtml) but may have other XSS issues (see https://en.wikipedia.org/wiki/Cross-site_scripting ) in plain HTML. The new test gets stuck before the production code fix and completes successfully and promptly after applying it.
platinumazure
approved these changes
Dec 20, 2018
|
@Krinkle @trentmwillis Are the test failures related to the changes in this PR? At a quick glance, I'm not sure they are, but maybe I'm missing something. |
|
They're unrelated, and have been fixed since the PR started. I'll close and re-open this PR so that GitHub creates a new merge commit and let Travis test that. |
|
My bad. The fix for that failure is still pending at #1339. I'll get that sorted now. |
|
Merged #1339, restarting Travis... |
|
On Thu, 20 Dec 2018 20:09:55 -0800 Trent Willis ***@***.***> wrote:
Merged #1341 into master.
fantastic! Thanks all!
…--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
http://www.shlomifish.org/humour/bits/Can-I-SCO-Now/ - “Can I SCO Now?”
“A is A, and A is not not-A? WTH is he talking about??! Of course A can be
not-A! I want a little of the stuff he’s on!”
— Initial reaction to the http://en.wikipedia.org/wiki/Organon
Please reply to list if it's a mailing list post - http://shlom.in/reply .
|
shlomif
added a commit
to shlomif/fc-solve
that referenced
this pull request
Dec 21, 2018
See qunitjs/qunit#1341 . The xhtml was invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an unescaped details.source in innerHTML.
It became apparent when using .xhtml (application/xml+xhtml) but may
have other XSS issues (see
https://en.wikipedia.org/wiki/Cross-site_scripting ) in plain HTML.
The new test gets stuck before the production code fix and completes
successfully and promptly after applying it.