Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (and add tests) missing required files in 2.9.0. #1368

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Fix (and add tests) missing required files in 2.9.0. #1368

merged 3 commits into from
Jan 7, 2019

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Jan 7, 2019 •
edited
Loading

eslint-plugin-node helps check for a large number of issues (deprecated APIs, requires from unpublished files, missing dependencies, etc).

The adds linting to ensure issues like the one reported in #1367 would fail CI:

Running "eslint:js" (eslint) task

/Users/rjackson/src/qunitjs/qunit/bin/qunit.js
  3:1   error  This file needs shebang "#!/usr/bin/env node"  node/shebang
  6:22  error  "../src/cli/run" is not published              node/no-unpublished-require
  7:31  error  "../src/cli/find-reporter" is not published    node/no-unpublished-require

✖ 3 problems (3 errors, 0 warnings)
  1 error, 0 warnings potentially fixable with the `--fix` option.

Warning: Task "eslint:js" failed.� Use --force to continue.

Aborted due to warnings.

Fixes #1367

@rwjblue
chore(tests) Add eslint-plugin-node for related files.
a2c75d7 
[eslint-plugin-node](https://github.com/mysticatea/eslint-plugin-node)
helps check for a large number of issues (deprecated APIs, requires from
unpublished files, missing dependencies, etc).
@rwjblue
chore(bin) Fix shebang in bin/qunit.js
9ba789a
@rwjblue
fix(bin) Ensure /src/cli/* is published.
1ad27bc
@rwjblue rwjblue changed the title chore(tests) Add eslint-plugin-node for related files. Fix (and add tests) missing required files in 2.9.0. Jan 7, 2019
@rwjblue rwjblue mentioned this pull request Jan 7, 2019
Closed
trentmwillis
trentmwillis approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing and adding linting to make sure it doesn't happen again

@trentmwillis trentmwillis merged commit 18581b3 into qunitjs:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmwillis trentmwillis trentmwillis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breakage in 2.9.0: Error: Cannot find module '../src/cli/run'
2 participants
@rwjblue @trentmwillis