Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Ensuring semaphores are balanced when timeout occurs #1376

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Core: Ensuring semaphores are balanced when timeout occurs #1376

merged 2 commits into from
Feb 21, 2019

Conversation

scalvert
Copy link
Contributor

Fixes #1375

rwjblue
rwjblue approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for working up the fix!

@stefanpenner
Copy link
Contributor

restarting the 2 failed jobs @scalvert you may need to investigate the failures if the reoccur.

@scalvert
Copy link
Contributor Author

Fixed. The regex for the tap output needed to be loosened to account for different stacks in versions of node.

@stefanpenner stefanpenner merged commit ba7453a into qunitjs:master Feb 21, 2019
@stefanpenner
Copy link
Contributor

I don't think I can release, so other maintainers will have to help with that yet.

@scalvert scalvert deleted the ensure-correct-recover branch February 21, 2019 05:17
@trentmwillis
Copy link
Member

Thanks! I'll cut a new release tomorrow.

@scalvert
Copy link
Contributor Author

Thanks, @trentmwillis! This one has been plaguing us for a while!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scalvert @stefanpenner @trentmwillis @rwjblue