Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display progress and runtime while test suite is executing #1398

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Display progress and runtime while test suite is executing #1398

merged 1 commit into from
Jun 18, 2019

Conversation

jerrypopsoff
Copy link
Contributor

Closes #1394

qunit-progress

rwjblue
rwjblue reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks for working on this!

platinumazure
platinumazure reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I would love another team member to review in case I missed something.

@jerrypopsoff
Copy link
Contributor Author

@platinumazure @rwjblue Any idea who I should contact about getting an additional review?

@stefanpenner
Copy link
Contributor

LGTM!

@stefanpenner stefanpenner merged commit cc1fdb6 into qunitjs:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@platinumazure platinumazure platinumazure left review comments

@stefanpenner stefanpenner stefanpenner approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display progress in test runner during test suite execution
4 participants
@jerrypopsoff @stefanpenner @rwjblue @platinumazure