Provide QUnit.test aliases for only/todo/skip #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QUnit.test.only === QUnit.only QUnit.test.todo === QUnit.todo QUnit.test.skip === QUnit.skip
Included aliases in test.md, pointing to QUnit main docs
|
Hmm, got a failure in "CLI Watch > properly watches files after initial run", only on Mac/Node10. Looks unrelated. |
Yeah, it started happening a few weeks ago. Possibly due to a change in Node.js or in Travis' Mac systems. I've re-run those builds, and they pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1402
#1402 called out these QUnit.test variants as aliases to the main QUnit functions, but to keep the code modular, I reversed that in the implementation to make the main QUnit functions aliases to the test implementations. Those are really the "shortcuts" at that level, and Test holds onto the real implementations (as it always had). These methods are now encapsulated and exposed only through the Test function/object, no longer as exported functions.
Our existing tests still use the main QUnit methods, which I think is perfectly valid.
I doc'ed these new aliases in Test.md, pointing to the existing main QUnit methods. I did not touch the main only/todo/skip docs to point to anything about these new aliases, but I could add a "Changelog" section in each to mention these? I didn't want to clutter.