-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Reporter: headers fixed, tests scrollable #1513
HTML Reporter: headers fixed, tests scrollable #1513
Conversation
Nice! This has been bugging me as well. Though it seems that QUnit follows jQuery's browser support policy, which still includes IE9+ among others. I'm not 100% sure, but I'm guessing CSS features like |
How many developers use qunit in IE9? I could understand if it was going out to the public but this is for devs. |
Maybe there are still teams out there that run their tests in older browsers as part of their CI/CD flow? It seems there have been CSS adjustments in the past to fix issues, so it doesn't seem that far-fetched to me that adding new styles should take into account the browser support policy. I could be wrong of course and if so, I apologise in advance. I'm sure someone of the QUnit team can confirm. Thanks for the fix anyways, will really improve the DX 👍. |
removed flexbox, vh and calc. Not responsive to header height any more. Suggest that flexbox is reinstated once the requirement to support IE9 is removed. |
Ah yes of course |
Absolutely - that's why I'd like to use flexbox. Frankly if someone is using this in CI in IE9 they don't care about the UX, only the results. Can we use flexbox and have a fallback to the old behaviour? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot!
Would it be possible to achieve this in a way that we only add styles to our own qunit-
elements? In particular, styling the body
element tends to cause test failures for integration tests that may temporarily render a UI component in a fixture or at the end of the body.
Yes. See new commit. |
I think that the best solution is flexbox - it will fall back to the current layout in IE9 - that's not broken, it's just not better. |
Here's the final version - does nothing if flexbox isn't supported, so has no effect on old browsers using |
@Krinkle good spot, fixed |
Test failure seems unrelated to the changes |
|
@BryanCrotaz This is good to go, but for the CLA signature pending. |
I've signed it but it still says it's pending. When I click on the pending notice it takes me to the form and says I've already signed it. Where do I go from here? |
…html-reporter-experience * commit '39dc8a53e90dd91c4cb30582ddc56585f2e3739b': Update qunit.css Update qunit.css ignore on small screens
Looks good now. Not sure what it was... Thank you! |
CSS change to keep test headers fixed at the top and make test results scrollable. Much improved dev experience.
Fixes #1512