feat: better logging for assertions after a test #1517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcclure15
reviewed
Nov 20, 2020
smcclure15
reviewed
Nov 20, 2020
smcclure15
reviewed
Nov 20, 2020
Krinkle
reviewed
Nov 23, 2020
Krinkle
approved these changes
Nov 24, 2020
Krinkle
pushed a commit
that referenced
this pull request
Nov 29, 2020
better logging for assertions after a test. the "Assertion after test" failure now includes the test name and assertion message. Closes #1517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into assertions happening after tests for one of our unit tests and locally made this change. It seems useful to know what test and what assertion are running after the test are supposed to have completed so I think that It would be nice to have this change in qunit.