Handle expect(0) as expected

[mmchaney]

I think that if something like the following fails

test("foo", function() {
    expect(1); ok(true, "foo"); ok(true, "bar");
});

then the following should fail too

test("foo", function() {
    expect(0); ok(true, "foo");
});

[jzaefferer]

You could do this.expected != null to simplify this. Also please keep the whitespace intact (missing space after opening paren).

[mmchaney]

Done and done. Thanks for the heads up.

[Krinkle]

We should also add unit tests for these two cases:

• expect(0) with >= 1 assertion should fail
• expect(0) with 0 assertions should succeed.

[mmchaney]

Writing the first test is easy but I don't think it would be good to have a test case that purposely fails. Actually we should test Test.prototype.finish to see if it adds a negative assertion for > 0 assertions and 0 expected. Yet I don't see how that's possible without mocking a bunch of internal methods and variables. Maybe I'm just missing something...

The second case would also pass without my changes.

Maybe the following argument will suffice to pull in these changes:

QUnit.test checks if expected is supplied and if not it sets it to null and not 0. So clearly there should be a difference between expected being 0 and expected being null. But the current check in QUnit.prototype.finish does not account for that (due to 0 being falsy). I think it's just an oversight that should not require a test case.

[jzaefferer]

The suggested change to have null mean something else then 0 sounds good.

[jzaefferer]

Landed!