Fix for Issue #163 (jsDump treats any object with a length property as an array) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odeList objects to be output as arrays This helps prevent treating any object with a length property as an array, while maintaining the ability to render NodeList objects as arrays. jsDump output tests still pass after this patch is applied.
This doesn't have any functional difference because we are comparing a string literal with the results of Object.toString(), but it's better to be sure that they are the same type.
|
Thanks, landed! Refactored slighlty to take advantage of a toString alias from another commit: a99a1f9 |
|
This breaks jsDump in IE: http://swarm.jquery.org/?state=runresults&run_id=2156&client_id=217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more strict array type detection for dump output, and allowed NodeList objects to be output as arrays
This helps prevent treating any object with a length property as an array, while maintaining the ability to render NodeList objects as arrays. jsDump output tests still pass after this patch is applied.
Fixes #163.