HTML Reporter: Fix display: none regression on global error message
#1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows-up 8f5e7ed, which fixed the bug where in the "No tests" error (or indeed any global error after tests are done running) could cause the test runner to get stuck. That change maintained backward compatibility by continuing to count these global errors as "failed tests", so that CI reporters listening for `QUnit.done()` on `QUnit.on("runEnd")` continue to get the same negative signal. And, it continued to visually render them as a failed test if they happen during test execution or as the last/only event. But... it inserted the element into the DOM without making visible, which fooled our internal unit tests. Fix qunitjs#1651.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows-up 8f5e7ed, which fixed the bug where in the "No tests" error (or indeed any global error after tests are done running) could cause the test runner to get stuck.
That change maintained backward compatibility by continuing to count these global errors as "failed tests", so that CI reporters listening for
QUnit.done()onQUnit.on("runEnd")continue to get the same negative signal. And, it continued to visually render them as a failed test if they happen during test execution or as the last/only event.But... it inserted the element into the DOM without making visible, which fooled our internal unit tests.
Fix #1651.