Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Upgrade commander from 7.2 to 12.1.0 #1781

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Jul 20, 2024

  1. ✅ Verify package publication metadata.
  2. ✅ Review package diffs.
  3. ✅ Repeat the above two steps for any changed or added indirect dependencies: None.
  4. ✅ What is this package used for: CLI options parsing.
  5. ✅ Test relevant use of package (how, if manually, or covered by CI): Covered by CI.

Verify publication to npm

Previously at #1564:

$ npm info commander@7.1.0

commander@7.1.0 | MIT | deps: none

maintainers:
- zhiyelee <zhiyelee@gmail.com>
- somekittens <rkoutnik@gmail.com>
- tjholowaychuk <tj@vision-media.ca>
- vanesyan <romain.vanesyan@gmail.com>
- shadowspawn <npm_j@ruru.gen.nz>
- abetomo <abe@enzou.tokyo>

published 3 weeks ago by abetomo <abe@enzou.tokyo>

Now:

$ npm info commander@12.1.0

commander@12.1.0 | MIT | deps: none

maintainers:
- somekittens <rkoutnik@gmail.com>
- tjholowaychuk <tj@vision-media.ca>
- shadowspawn <npm_j@ruru.gen.nz>
- abetomo <abe@enzou.tokyo>

published 2 months ago by abetomo <abe@enzou.tokyo>
  • ✅ Published by the same account as a previous release: Yes.
  • ✅ New maintainer(s): (none).
  • ✅ Added dependencies: (none).
  • ✅ Changed dependencies: (none).

Review package diffs

Review package diffs, use npm diff ---diff commander@7.2.0 --diff commander@12.1.0 --color=always or https://diff.intrinsic.com.

  • Raise Node.js requirement from 10 to 18.
  • Deprecation and removal of methods we don't use.
  • Changes to types we don't use.
  • Moved most internal code from index.js to lib/command.js.
  • Change export of program via require() CommonJS from default to named export.

✅ LGTM.

See also changelog at https://github.com/tj/commander.js/blob/v12.1.0/CHANGELOG.md

@Krinkle Krinkle merged commit 5c5538d into qunitjs:main Jul 20, 2024
10 checks passed
@Krinkle Krinkle deleted the upgrade-commander branch July 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant