Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme #62

Closed
wants to merge 2 commits into from
Closed

New theme #62

wants to merge 2 commits into from

Conversation

NV
Copy link
Contributor

@NV NV commented Dec 5, 2010

Screenshot of the new QUnit clean theme

I've made a new theme for QUnit. I think it's more readable (e.g. doesn't use bold typeface for test names) and less cluttered.

An example in the wild.

@eduardocereto
Copy link

I liked the template. Maybe Qunit could host this template on a separated css file. So users may choose the one they like best.

@markstory
Copy link

This is nice looking, a bit simpler to read than the default QUnit template/stylesheet.

@jzaefferer
Copy link
Member

I've (finally) checked this out. By now various other stuff changed, so it needs an update. As I don't really want to replace the current theme, I've created a addons/themes folder, for now in branch: https://github.com/jquery/qunit/commits/nv-theme

Would be great if you could take that and update/polish it a bit. Planning to add more addons sometime soon, and list them on the site.

@jzaefferer jzaefferer closed this Aug 5, 2011
@Krinkle
Copy link
Member

Krinkle commented Apr 4, 2012

I don't know how the end result looked like but from the screenshot I have a few points:

  • Gold background color. It makes it (in my opinion) a lot less clean.
  • Bright separator line under the header becomes almost invisible
  • Green test result numbers in parentheses are harder to read with the gold background
  • Red test result number don't contrast very well (red and green are a bad combination)
  • Test titles (before the : colon) are dark green, that on a golden background is harder to read.

@jzaefferer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants