-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add in-situ analysis #586
Conversation
I'll hold off on reviewing this until #581 is finalized and merged, since the exact functionality is still being iterated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
I've re-worded things to avoid "weighting" as you suggested. Let me know if it is sufficiently clear. |
@markkrumholz Can you re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two final minor comments: in the example input file for on-the-fly PDFs, the documentation / comments do not currently state the default behavior for the weight-by and min/max options. You should state what these default to, i.e., if you don't specify how to weight, is it weighted by mass, volume, cell count? What are the default choices for min/max if you don't specify?
I've added both of these. See inline comments. |
Description
Adds documentation for enabling in-situ analysis of simulations.
Also: updates the documentation on how to read a time series of plotfiles with VisIt.
Related issues
N/A
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.