Use mass scalars while computing EOS quantities in NSCBC #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
April 17, 2024 14:29
psharda
commented
Apr 17, 2024
|
I don't think any of the current test problems are using the NSCBC? If true, how can we check the changes actually work |
Test problems are here: https://github.com/quokka-astro/quokka/tree/development/src/NSCBC |
psharda
commented
Apr 17, 2024
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
psharda
changed the title
for more information, see https://pre-commit.ci
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
|
@BenWibking can it be approved now? |
BenWibking
approved these changes
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Hmm, @BenWibking , one of the radiation tests timed out during merge. |
|
Ah, that keeps happening. You can retry the merge until it works, or you can increase the timeout for that test. Or ask Chongchong to adjust the parameters so it doesn't take as long to run. |
Merged
via the queue into
quokka-astro:development
with commit Apr 19, 2024
7778c4c
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently do not pass mass scalars as an input to the
ComputeSoundSpeedfunction in NSCBC.Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.