Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine PRIMORDIAL_CHEM preprocessor as CHEMISTRY #724

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Aug 29, 2024

Description

Now that we are going to have metal+dust chemistry, redefine the ifdef to CHEMISTRY

Related issues

Will be useful for #723

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • [] I have requested a reviewer for this PR.

@psharda
Copy link
Contributor Author

psharda commented Aug 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 29, 2024
Copy link

sonarcloud bot commented Aug 29, 2024

@psharda psharda marked this pull request as ready for review August 29, 2024 19:12
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 29, 2024
@BenWibking BenWibking added this pull request to the merge queue Aug 29, 2024
Merged via the queue into quokka-astro:development with commit e7ced44 Aug 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants