-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put short delay between each publish in RepublishAll #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about panic vs returning error. The build also fails, although it might be a fluke.
republisher/main.go
Outdated
return net.(*network.RemoteNetwork).RepublishAll() | ||
err = net.(*network.RemoteNetwork).RepublishAll() | ||
if err != nil { | ||
panic(errors.Wrap(err, "error on publish")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better to return the error here, since the function has an error
return type?
failure is due to dgraph-io/badger#886 |
i just pushed rebuild on this. |
republisher/main.go
Outdated
@@ -52,7 +57,12 @@ func doIt(ctx context.Context) error { | |||
panic(errors.Wrap(err, "setting up network")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error return here too I guess (but I realize that was the old code)
fc49844
to
cb85074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when green
theory is that community block store is filling up its ingress buffer inside libp2p
cb85074
to
4e39914
Compare
blocks were getting published on andrew's box, but weren't appearing on the community hub node. Theory is that community block store is filling up its ingress buffer inside libp2p, so putting a short delay between