Drop --debug option

It's been doing nothing for years, and there's no clear way of making
it useful. From the looks of it, the option name is ambiguous: is it
to enable execution of Quaternion with a debugger? Extra checks? Debug
logging, as #415 hints (though one switch for debug logging is
not really enough)?

This commit drops the option and the related functions (that do
effectively nothing). Closes #415 in its current form; #787 is created
to track logging categories support in Quaternion and also introduction
of handy command-line switches with better names than --debug.

client/chatedit.cpp

@@ -27,6 +27,7 @@
 #include <QtGui/QKeyEvent>
 #include <QtCore/QMimeData>
 #include <QtCore/QStringBuilder>
+#include <QtCore/QDebug>
 
 #include <util.h>
 

client/chatroomwidget.cpp

@@ -243,12 +243,6 @@ ChatRoomWidget::ChatRoomWidget(QWidget* parent)
     setLayout(layout);
 }
 
-void ChatRoomWidget::enableDebug()
-{
-    QQmlContext* ctxt = m_timelineWidget->rootContext();
-    ctxt->setContextProperty(QStringLiteral("debug"), true);
-}
-
 QuaternionRoom* ChatRoomWidget::currentRoom() const { return m_messageModel->room(); }
 
 void ChatRoomWidget::setRoom(QuaternionRoom* newRoom)

client/chatroomwidget.h

@@ -54,7 +54,6 @@ class ChatRoomWidget: public QWidget
 
         explicit ChatRoomWidget(QWidget* parent = nullptr);
 
-        void enableDebug();
         bool pendingMarkRead() const;
         QuaternionRoom* currentRoom() const;
 

client/main.cpp

@@ -151,10 +151,6 @@ int main( int argc, char* argv[] )
     QCommandLineOption hideMainWindow { QStringLiteral("hide-mainwindow"),
         QApplication::translate("main", "Hide main window on startup") };
     options.append(hideMainWindow);
-    QCommandLineOption debug { QStringLiteral("debug"),
-        QApplication::translate("main", "Display debug information") };
-    debug.setFlags(QCommandLineOption::HiddenFromHelp); // FIXME, #415
-    options.append(debug);
     // Add more command line options before this line
 
     if (!parser.addOptions(options))
@@ -190,11 +186,6 @@ int main( int argc, char* argv[] )
     Quotient::NetworkSettings().setupApplicationProxy();
 
     MainWindow window;
-    if (parser.isSet(debug))
-    {
-        qInfo() << "Debug mode enabled";
-        window.enableDebug();
-    }
 
     ActivityDetector ad(app, window); Q_UNUSED(ad);
     if (parser.isSet(hideMainWindow)) {

client/mainwindow.cpp

@@ -763,11 +763,6 @@ bool MainWindow::saveAccessTokenToKeyChain(const AccountSettings& account,
 }
 #endif
 
-void MainWindow::enableDebug()
-{
-    chatRoomWidget->enableDebug();
-}
-
 void MainWindow::addConnection(Connection* c, const QString& deviceName)
 {
     Q_ASSERT_X(c, __FUNCTION__, "Attempt to add a null connection");

client/mainwindow.h

@@ -59,8 +59,6 @@ class MainWindow: public QMainWindow, public Quotient::UriResolverBase {
         MainWindow();
         ~MainWindow() override;
 
-        void enableDebug();
-
         void addConnection(Connection* c, const QString& deviceName);
         void dropConnection(Connection* c);