Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgetting should be confirmed by the user #236

Open
KitsuneRal opened this issue Dec 21, 2017 · 1 comment · May be fixed by #907
Open

Forgetting should be confirmed by the user #236

KitsuneRal opened this issue Dec 21, 2017 · 1 comment · May be fixed by #907
Labels
enhancement A feature or change request for Quaternion good first issue Looks easy to fix, a good first issue help wanted More information/contribution needed

Comments

@KitsuneRal
Copy link
Member

Since this action is irreversible, Quaternion should ask the user to confirm the intention.
@KitsuneRal KitsuneRal mentioned this issue Dec 21, 2017
Open
@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Dec 21, 2017
@KitsuneRal
Copy link
Member Author

A very easy way would be to introduce a QMessageBox::question in the right place of the code. An even better way would be to wait for the repurposed "system dialog panel" (#215) and use it for the same kind of interaction.

@KitsuneRal KitsuneRal added good first issue Looks easy to fix, a good first issue help wanted More information/contribution needed labels Dec 21, 2017
@marcdeop marcdeop mentioned this issue Mar 18, 2018
Open
nicolasfella pushed a commit to nicolasfella/Quaternion that referenced this issue Dec 27, 2020
@KitsuneRal
Connection: load supported room versions
e12fc32 
A part of quotient-im#236.
nicolasfella pushed a commit to nicolasfella/Quaternion that referenced this issue Dec 27, 2020
@KitsuneRal
Room::checkVersion() and Room::unstableVersion()
ac7d2ad 
Initial (sans power levels checking) implementation of the check that
room should be upgraded. Closes most of quotient-im#236.
nicolasfella pushed a commit to nicolasfella/Quaternion that referenced this issue Dec 27, 2020
@KitsuneRal
Room::switchVersion()
11b1bfe 
Closes quotient-im#236.
@KitsuneRal KitsuneRal moved this to 0.1 - To Do in Quaternion 1 Jul 22, 2024
@dymoksc dymoksc linked a pull request Oct 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature or change request for Quaternion good first issue Looks easy to fix, a good first issue help wanted More information/contribution needed
Projects
Quaternion 1
Status: 0.1 - To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a confirmation message box before forgetting a room dymoksc/Quaternion
2 participants
@marcdeop @KitsuneRal