Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions render HTML #789

Closed
KitsuneRal opened this issue Sep 12, 2021 · 0 comments
Closed

Reactions render HTML #789

KitsuneRal opened this issue Sep 12, 2021 · 0 comments
Assignees
@KitsuneRal
Labels
security Security- or privacy-related issue

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Sep 12, 2021 •
edited
Loading

Reaction keys and author names next to them are not supposed to be in rich text, yet HTML markup in them gets rendered. This exposes Quaternion users to arbitrary HTML+CSS (but not JavaScript) from the "basic subset" supported by Qt. The problem exists since introduction of reactions in earlier 0.0.9.5 builds but doesn't affect any 0.0.9.4 releases (as those don't have reactions).

Thanks to nephele for uncovering the original bug as well as testing out the fixes.
@KitsuneRal KitsuneRal added the security Security- or privacy-related issue label Sep 12, 2021
@KitsuneRal KitsuneRal self-assigned this Sep 12, 2021
@KitsuneRal KitsuneRal reopened this Sep 12, 2021
KitsuneRal added a commit that referenced this issue Sep 28, 2021
@KitsuneRal
Reactions: show plain text instead of HTML with escaping
410a832 
This is a more careful fix of #789 - previous fix caused an interesting
regression where clicking on a reaction with HTML-unsafe characters led
to creating a distinct reaction with those characters carefully
HTML-escaped at the source (let alone the overescaped text showing up
in the tooltip).

Also: fix the number of authors being off whenever there were more than 7.
@KitsuneRal KitsuneRal moved this to Version 0.0.95 - Done in Quaternion 1 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
security Security- or privacy-related issue
Projects
Quaternion 1
Status: Version 0.0.95 - Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal