Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lazy-loading member lists #253

Closed
KitsuneRal opened this issue Nov 4, 2018 · 4 comments
Closed

Support lazy-loading member lists #253

KitsuneRal opened this issue Nov 4, 2018 · 4 comments
Assignees
@KitsuneRal
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

Having an account at status.im means most likely being in 5+ 'default' rooms with ~10k users in each - most of them doing nothing.
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Nov 4, 2018
@KitsuneRal KitsuneRal self-assigned this Nov 11, 2018
@KitsuneRal
Copy link
Member Author

KitsuneRal commented Nov 11, 2018 •
edited
Loading

CS API PR: matrix-org/matrix-spec-proposals#1287 matrix-org/matrix-spec-proposals#1758

@KitsuneRal
Copy link
Member Author

KitsuneRal commented Nov 16, 2018 •
edited
Loading

Things to address once lazy-loading is on:

  • The list of users shows an incorrect total number (9b3e437)
  • Tab-completion for not-yet loaded users doesn't work (f0bd24a)
  • Loading historical messages doesn't add members seen in those messages to the members list (e1fdb33)

@KitsuneRal
Copy link
Member Author

It's apparently prudent to load the list of members for the displayed room out-of-sync-band to address both remaining items above.

KitsuneRal added a commit that referenced this issue Nov 23, 2018
@KitsuneRal
Connection: support members lazy-loading
608f2f7 
This should cover the Connection-related part of #253.

Connection gained lazyLoading/setLazyLoading accessors and the respective Q_PROPERTY.
When lazy loading is on, sync() adds lazy_load_members: true to its filter.
KitsuneRal added a commit that referenced this issue Dec 8, 2018
@KitsuneRal
Connection: support members lazy-loading
a4d6a37 
This should cover the Connection-related part of #253.

Connection gained lazyLoading/setLazyLoading accessors and the respective Q_PROPERTY.
When lazy loading is on, sync() adds lazy_load_members: true to its filter.
KitsuneRal added a commit that referenced this issue Dec 8, 2018
@KitsuneRal
Connection: support members lazy-loading
1ff8a0c 
This should cover the Connection-related part of #253.

Connection gained lazyLoading/setLazyLoading accessors and the respective Q_PROPERTY.
When lazy loading is on, sync() adds lazy_load_members: true to its filter.
KitsuneRal added a commit that referenced this issue Dec 9, 2018
@KitsuneRal
Room: defer memberListChanged(); track room summary changes
9b3e437 
This concludes beta-version of lazy-loading support in libQMatrixClient (#253).
@KitsuneRal
Copy link
Member Author

As of the commit above, lazy-loading members looks working; full-loading the list of members upon displaying the room is on the way.

KitsuneRal added a commit that referenced this issue Dec 11, 2018
@KitsuneRal
Make Room::setDisplayed() trigger loading all members
f0bd24a 
Closes #253.
@KitsuneRal KitsuneRal mentioned this issue Dec 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: Version 0.5(.x) - Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal