Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in thread updating #856

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vkrause
Copy link
Member

@vkrause vkrause commented Jan 17, 2025

Happened at startup/sync in Itinerary, due to Thread::addEvent() being called with a nullptr event from here.

Happened at startup/sync in Itinerary, due to Thread::addEvent() being
called with a nullptr event from here.
@KitsuneRal
Copy link
Member

If it's nullptr how did it end up in the timeline?

@KitsuneRal
Copy link
Member

What you're guarding against is rather the thread root event somehow is not RoomMessageEvent, and it normally just shouldn't happen. I'm just trying to make sure we're not masking a problem instead of fixing it.

@vkrause
Copy link
Member Author

vkrause commented Jan 17, 2025

Right, I have no idea about the context of all this, and it's very well possible this is just hiding the problem (the application isn't doing anything with threads on its own). I can reliably reproduce this in one installation here, so I can test other approaches or diagnostics as well.

@nvrWhere
Copy link
Collaborator

Agree with @KitsuneRal here all thread roots should be room message events. That being said I don't think the server would stop a client from adding a thread relation to an invalid root. So I think we need this but it's also worth checking that there isn't something else going on.

@vkrause can you get the JSON for the problem event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In work
Development

Successfully merging this pull request may close these issues.

3 participants