This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Eslint added #345
Merged
Eslint added #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the most painful PRs ever... |
| </div> | ||
| </li> | ||
| )); | ||
| }; | ||
| } | ||
|
|
||
| render() { | ||
| const { surahs, ayat } = this.state; | ||
|
|
||
| return ( | ||
| <div className={`${styles.autocomplete} ${ayat.length || surahs.length ? '' : 'hidden'}`}> |
There was a problem hiding this comment.
index.js?8fa9*:219 Uncaught TypeError: Cannot read property 'length' of undefined
this happened upon initial click/focus into the search field
| @@ -87,7 +87,7 @@ export default class Track extends Component { | |||
| const { shouldRepeat, onEnd, isStarted, doStop, currentAyah, surah } = this.props; | |||
|
|
|||
| // if we're on the last ayah, do a full stop at the playback end | |||
| if (`${currentAyah === surah.id}:${surah.ayat}`) return doStop(); | |||
| if (currentAyah === `${surah.id}:${surah.ayat}`) return doStop(); | |||
There was a problem hiding this comment.
oh wow! Nice find!
|
okay this is good to go |
mmahalwy
added a commit
that referenced
this pull request
Jun 25, 2016
* Eslint added * eslint in travis * ayah require * Fixed * fixed bug that was preventing ayah transition on audioplayer * fix autocomplete thing
mmahalwy
added a commit
that referenced
this pull request
Jun 25, 2016
* Eslint added * eslint in travis * ayah require * Fixed * fixed bug that was preventing ayah transition on audioplayer * fix autocomplete thing
mmahalwy
added a commit
that referenced
this pull request
Jun 25, 2016
* Change * Eslint added (#345) * Eslint added * eslint in travis * ayah require * Fixed * fixed bug that was preventing ayah transition on audioplayer * fix autocomplete thing * Extract connect from the surah container (#347) * Fout fonts (#346) * Fout fonts * wip * wip2 * do not update * pass tests
mmahalwy
added a commit
that referenced
this pull request
Jul 10, 2016
* HOTFIX reading mode markers (#303) * Default api and files (#306) * Reducing bundle size (#310) * Reducing bundle size * rearranged files * more rearrange and deleted unneeded files * add default segments key (#313) * transitioning to al-quran al-kareem (#314) transitioning to Al-Quran al-Kareem * Fix lint issues * Update Readme.md * Add devDependency Status * Update Readme for new developers * Code splitting assets (#321) * Code splitting * Split the html files into their own and ajax requested * Pass tests * Wrong files * Add segments * Add segments * Autocomplete pointing to v2 suggest * HOTFIX pretty-error dep (#323) * HOTFIX Search to the right route (#324) * No segments for non-segmented reciters (#325) * Adding sentry (#327) * CDN images for surahinfo (#328) * Reduce data dehydration (#329) * Search Action on homepage (#330) * Descriptions for surahs (#331) * Fixed head tags (#332) * Head tags improved and more organized * Fixed the head problem * audioplayer bug fixes, or more bugs (#335) * audioplayer bug fixes, or more bugs * removes some unneeded state things in audioplayer redux, also fixes a bug where event listeners would get bound without properly unbinding multiple times, which caused the player to skip ayahs after using next <-> prev more then once on the same ayah * temporarily disables word focusing capacity * Add sourcemaps to prod * Remove zero padding in urls * (WIP) Issue #248 (#336) Fixes #248 Out of range bug * correct waffle url. (#338) * JS error on surah click (#349) * Add Heroku generated app.json * Ramadan Todo list (#343) * Change * Eslint added (#345) * Eslint added * eslint in travis * ayah require * Fixed * fixed bug that was preventing ayah transition on audioplayer * fix autocomplete thing * Extract connect from the surah container (#347) * Fout fonts (#346) * Fout fonts * wip * wip2 * do not update * pass tests * Sourcemap for sentry (#352) * contribution guideline (#355) * Heroku pipeline trials (#354) * push * push * push * push * push * Heroku push (#356) * Heroku push * public urls * Add zendesk widget (#358) * Fix font artifacts This fixes #365 by merging the 3 fonts from quran/quran.com-images#7, quran/quran.com-images#8, and quran/quran.com-images#9. * Update font for page 237 to fix spacing in 12:17 This fixes the spacing issue in 12:17 by updating the font. Fixes #369. * Feature/341 social share (#367) * Add zendesk widget (#358) * The first commit's message is: * Simplify audioplayer (#360) * Audioplayer refactor * more reshuffling * move logic outside of tracker * fixes #359 * eslint * refactor and works * Added segments * Fix navigating from home to surah * reciter change * on word click working! * segments encryption and lazy decryption * encryption lib * linter is happy * unit tests * env * Fix sentry bug (#373) * Fix sentry bug * no build * #372 colon separated surah/ayah (#374) * #372 colon separated surah/ayah * #372 colon separated surah/ayah * #372 colon separated surah/ayah * Re-output fonts with Apple option enabled This probably doesn't matter for web, but it may matter for apps in the future, plus wanted to keep in sync with the versions of the fonts used by quran/quran.com-images. * Tooltip options for translation and transliteration (#376) * Reading mode single line (#377) * - ayah's have link (discuss, maybe not needed) (#379) - Fix audio player playing text - Remove unneeded padding on mobile - Hide Share on mobile devices (native share is built into the browsers) * Added Mixpanel (#384) * Remove footer links (#385) * Remove footer links * eslint * Fix json-ld (#386)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.