This repository has been archived by the owner on Nov 16, 2018. It is now read-only.
allow empty or invalid initial date #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR really need to be merged ! I'm having the same issue with empty date and I cannot apply some validation on it since it's always returning "Invalid date". |
|
I've grabbed those changes and they're working really well. Thanks @djonin |
|
what about a merge? :) |
|
This project seems to be dead, so your best option is probably to clone it and apply your changes (or to look for another datepicker, ahem). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the user to pass in an invalid date. The viewDate will be initialised to the current month. The inputValue will be initialised to empty string. The selectedDate property will stay invalid (no date selected) until either the user selects a date or toggles the time picker, at which point the date picker will be initialised to the current date and time.
Also fixed the AM/PM switch adding 12 hours instead of subtracting when you switch from 12:xx noon to midnight.
This merge should fix issues #159 #148 and #100.