Pathlib /tests/conftest.py

[ghost]

#176

[The-Compiler]

I think this can be fixed in a nicer way: According to the reference docs, the pytest_ignore_collect hook has a fspath argument which you can use instead of path. That will mean fspath is a pathlib.Path object as well.

[ghost]

@The-Compiler pytest doesn't seem to contain the pathlib argument which is weird

def pytest_ignore_collect(path: py.path.local, config: "Config") -> Optional[bool]:

in .tox/py*/lib64/python3.*/sites-packages/_pytest/hookspeck.py

Doesnt seems like the pahlib changes made it in 6.2.X :(

[The-Compiler]

Yep, you're right - they were added on December 15th and I blindly assumed there was a release since then, but the last feature release was on December 12th...

Looks like there are some issues with that change still, see pytest-dev/pytest#8361 and pytest-dev/pytest#8463.

Would you mind changing this to use the py.path API in the meantime? I don't think it makes much sense to convert from py.path to str to pathlib and back here until pytest is ready.

[RonnyPfannschmidt]

I apologise for the inconvenience, just wrap up the path into a pathlib path for now

[The-Compiler]

No worries! But you're right, let's do something like fspath = pathlib.Path(path) (or perhaps pathlib.Path(str(path)), not sure) so we can already use the pathlib API and then easily migrate once the new API is available.

[RonnyPfannschmidt]

The canonical api is os.fspath, i believe pathlib calls it, so Str should not be needed

[The-Compiler]

Looks great now, thanks! 👍